Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Blazor WebAssembly notifications #4018

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

captainsafia
Copy link
Member

Addresses dotnet/aspnetcore#23832

  • Removes unnecessary check for nightly JS debugging extension
  • Adds "Don't ask again" option to Blazor WASM debugging notification

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #4018 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4018   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          60       60           
  Lines        1856     1856           
  Branches      214      214           
=======================================
  Hits         1596     1596           
  Misses        200      200           
  Partials       60       60           
Flag Coverage Δ
#integration 100.00% <ø> (ø)
#unit 85.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be36af...8ef7488. Read the comment docs.

Copy link
Contributor

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@JoeRobich
Copy link
Member

@JoeRobich JoeRobich merged commit c14e928 into dotnet:master Aug 26, 2020
@JoeRobich
Copy link
Member

@captainsafia Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants